stick with proj.lib on windows #1581
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's an issue with proj.lib coming from the library, and proj.lib coming from the src/apps/proj.cpp utility. This shows up only in the x86 builds which use -DBUILD_LIBPROJ_SHARED=OFF |
on it |
jef-n
force-pushed
the
win-no-abi-lib
branch
from
6e766f6 to
6b99e02
Compare
|
Resolves #1479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd suggest to keep using proj.lib as library name - even if the dll is called differently. Had to adapt the lib name twice in the last few days for QGIS and GDAL…