CMake: replace PROJ_TESTS with CTest's BUILD_TESTING option #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @mwtoews ! It would be nice to mention in the docs that you can turn testing off, in the CMake section in https://github.com/OSGeo/PROJ/blob/master/docs/source/install.rst I take it that we will want to remove the |
* CTest automatically creates a BUILD_TESTING option (default is ON) * Also allow PROJ_TESTS to be used, but show deprecation message; and add note to remove this option by PROJ 8.0 * Only build geodtest when tests are enabled * Add documentation to configure a build using -DBUILD_TESTING=OFF
mwtoews
force-pushed
the
build-testing
branch
from
f95c64c to
43dc8c5
Compare
|
I've updated |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1263 this PR replaces
PROJ_TESTSwith CTest'sBUILD_TESTINGoption, which is more generic to CMake projects. CTest (when included) automatically creates aBUILD_TESTINGoption, with a default ON. Backwards compatibility to the older optionPROJ_TESTSis supported, but shows a deprecation message.For example, a speedy build that does not require tests, configure a build like this:
(as expected)