tests: force use of bash for proj_add_test_script_sh #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
approved these changes
Feb 4, 2020
|
Do the test scripts contain bash specifics or can we get by using |
|
I am not too familiar with shell so I can't really comment. I think the |
|
It is probably safest to go with bash for now. Thanks for fixing this problem. |
|
Pleasure, thanks for merging. |
kbevers
added a commit
that referenced
this pull request
Feb 4, 2020
tests: force use of bash for proj_add_test_script_sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to run the tests on an Alpine Linux system that uses ash shell by default. This causes all
proj_add_test_script_shtests to error withsystem error -8 BAD COMMAND. Installing bash is not a problem, but this commit is required to force it to use bash.