Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/Makefile.am: remove bashism #2044

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

rouault
Copy link
Member

@rouault rouault commented Mar 10, 2020

No description provided.

@kbevers
Copy link
Member

kbevers commented Mar 10, 2020

Are checkbashisms and shellcheck quick to run against our makefiles etc? Might be a good idea to include those checks in the CI infrastructure.

@rouault
Copy link
Member Author

rouault commented Mar 10, 2020

Are checkbashisms and shellcheck quick to run

They are quick to run, but a Makefile isn't a shell script, so false positive warnings (or legit warnings that we have no influence on because this isn't in the generated part of Makefile) are probably to be expected. And are actually found, like in

script data/Makefile does not appear to have a #! interpreter line;
you may get strange results
possible bashism in data/Makefile line 144 ([^] should be [!]):
am__nobase_list = $(am__nobase_strip_setup); \
  for p in $$list; do echo "$$p $$p"; done | \
  sed "s| $$srcdirstrip/| |;"' / .*\//!s/ .*/ ./; s,\( .*\)/[^/]*$$,\1,' | \
  $(AWK) 'BEGIN { files["."] = "" } { files[$$2] = files[$$2] " " $$1; \
    if (++n[$$2] == $(am__install_max)) \
      { print $$2, files[$$2]; n[$$2] = 0; files[$$2] = "" } } \
    END { for (dir in files) print dir, files[dir] }'

@kbevers
Copy link
Member

kbevers commented Mar 10, 2020

Ah, I see. Yeah, that's not going to work. I guess we will just have to be careful about this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants