Bugfix in CRS::alterCSLinearUnit for DerivedProjectedCRS #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernando
force-pushed
the
fix-alter-cs-linear-unit
branch
2 times, most recently
from
fd82392 to
031f506
Compare
The implementation was calling alterUnit on the CS of the base projected CRS, but this CS could be different than that of the derived projected CRS being modified (e.g. the axes could be swapped). The fix consist on altering the unit of the derived projected CRS, but only if the CS can be cast to Cartesian. It's doesn't look like other CS types need to be considered.
hernando
force-pushed
the
fix-alter-cs-linear-unit
branch
from
031f506 to
2d82ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was calling
alterUniton the CS of the base projected CRS, but this CS could be different than that of the derived projected CRS being modified (e.g. the axes could be swapped).The fix consist on altering the unit of the derived projected CRS, but only if the CS can be cast to Cartesian. It's doesn't look like other CS types need to be considered.