You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't really use it, but I noticed it so just as a heads up.
GetOutputDriversFor in the python bindings is a duplicated implementation of the cpp version in commonutils.cpp, but it isn't really up-to-date anymore: eg. the specific logic to handle ".gpkg.zip" and ".shp.zip" isn't implemented.
I also noticed a bug: in the python version of DoesDriverHandleExtension the space-delimited extensions aren't split but just a string-find is used. This leads to too many drivers being returned: e.g. for .geojson 2 drivers are returned (GeoJSON and GeoJSONSeq) instead of only GeoJSON because extension "geojson" is also found in the string "geojsonl geojsons".
Possibly it would be better if the cpp version would be reused one way or the other to avoid the double implementation...
The text was updated successfully, but these errors were encountered:
I don't really use it, but I noticed it so just as a heads up.
GetOutputDriversFor in the python bindings is a duplicated implementation of the cpp version in commonutils.cpp, but it isn't really up-to-date anymore: eg. the specific logic to handle ".gpkg.zip" and ".shp.zip" isn't implemented.
I also noticed a bug: in the python version of
DoesDriverHandleExtension
the space-delimited extensions aren'tsplit
but just a string-find is used. This leads to too many drivers being returned: e.g. for.geojson
2 drivers are returned (GeoJSON
andGeoJSONSeq
) instead of onlyGeoJSON
because extension"geojson"
is also found in the string"geojsonl geojsons"
.Possibly it would be better if the cpp version would be reused one way or the other to avoid the double implementation...
The text was updated successfully, but these errors were encountered: