Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse dms in ISG format #10297

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Parse dms in ISG format #10297

merged 1 commit into from
Jun 25, 2024

Conversation

jjimenezshaw
Copy link
Contributor

@jjimenezshaw jjimenezshaw commented Jun 25, 2024

What does this PR do?

Parses ISG files that use "dms" format for "coord units"

Context:
Trying to read the new geoid model for Japan, that is for now in beta.
https://www.gsi.go.jp/buturisokuchi/grageo_reference.html
https://www.gsi.go.jp/butsuri/data/GSIGEO2024beta.zip
I found it was not parsed by GDAL
It is in ISG 2.0 format
https://www.isgeoid.polimi.it/Geoid/ISG_format_v20_20200625.pdf
using dms for "coord units"

Tasklist

  • Make sure code is correctly formatted (cf pre-commit configuration)
  • Add test case(s)
  • Add documentation
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.251% (-0.003%) from 69.254%
when pulling 4946532 on jjimenezshaw:isg-dms
into 1015b1c on OSGeo:master.

@rouault rouault merged commit abc5f9e into OSGeo:master Jun 25, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants