Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: enable gdal_priv.h precompiled header if CMake USE_PRECOMPILED_HEADERS=ON #11409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 2, 2024

Can speed up cold builds by 30%

It is a bit experimental for now, so it isn't enabled by default, because:

  • it currently causes linking issues with MSVC
  • CLang Static Analyzer analysis has false positives with it
  • Strange issue seen in the android CI configuration with a fatal error: file '/home/runner/work/gdal/gdal/build_android_cmake/CMakeFiles/gdal_priv_header.dir/cmake_pch.h' has been modified since the precompiled header '/home/runner/work/gdal/gdal/build_android_cmake/CMakeFiles/gdal_priv_header.dir/cmake_pch.h.pch' was built: mtime changed (https://github.com/rouault/gdal/actions/runs/12113235664/job/33767887119)

@rouault rouault added the funded through GSP Work funded through the GDAL Sponsorship Program label Dec 2, 2024
…_HEADERS=ON

Can speed up cold builds by 30%

It is a bit experimental for now, so it isn't enabled by default, because:
- it currently causes linking issues with MSVC
- CLang Static Analyzer analysis has false positives with it
- Strange issue seen in the android CI configuration with a
  fatal error: file '/home/runner/work/gdal/gdal/build_android_cmake/CMakeFiles/gdal_priv_header.dir/cmake_pch.h' has been modified since the precompiled header '/home/runner/work/gdal/gdal/build_android_cmake/CMakeFiles/gdal_priv_header.dir/cmake_pch.h.pch' was built: mtime changed (https://github.com/rouault/gdal/actions/runs/12113235664/job/33767887119)
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.71% (-1.5%) from 74.172%
when pulling 9b04b5a on rouault:precompiler_headers
into 57833dc on OSGeo:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants