FlatGeobuf writing: in SPATIAL_INDEX=NO mode, deal with empty geometries as if there were null #11420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rouault confirmed. I either like to pretend they do not exist or treat them as null geometry. |
…ies as if there were null - this fixes the crash when writing an empty polygon. Fixes OSGeo#11419 - this avoids a reading error when writing an empty line
rouault
force-pushed
the
flatgeobuf_empty_geoms
branch
from
389e438
to
d87e68e
Compare
|
Also add support for writing a file without feature in SPATIAL_INDEX=NO mode ( @bjornharrtell no reason why we should disallow this, right ? since writing empty files in SPATIAL_INDEX=YES mode already works) |
rouault
force-pushed
the
flatgeobuf_empty_geoms
branch
from
d87e68e
to
e6cb834
Compare
rouault
force-pushed
the
flatgeobuf_empty_geoms
branch
from
e6cb834
to
c59ee22
Compare
No, must been an oversight that it wasn't doing so already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bjornharrtell Can you confirm that FlatGeobuf is not a fan of EMPTY geometries ?