swig/python_exceptions.i: Add Context Manager for handling Python exception state #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Would you mind also comitting the regnerated bindings file ?
Cf https://github.com/OSGeo/gdal/blob/master/CONTRIBUTING.md#build-swig to have SWIG 4.0.2 and also note you need to pass -DSWIG_REGENERATE_PYTHON=ON to CMake
It would be great to have testing of this class, for example in autotest/gcore/basic_test.py
|
Thanks @rouault Have added the four regenerated bindings, and a simple test where you suggested. Thank you! |
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Mar 17, 2023
PR OSGeo#6637 introduced a gdal/ogr/osr.ContextMgr() class, which I forgot when committing 26151f7 ("Python bindings: add gdal.enable_exceptions() context manager") in PR So: - remove this redundant gdal/ogr/osr.enable_exceptions() - remove gdaltest/ogrtest.enable_exceptions() - use ContextMgr() instead - and make its useExceptions argument default to True
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Mar 17, 2023
PR OSGeo#6637 introduced a gdal/ogr/osr.ContextMgr() class, which I forgot when committing 26151f7 ("Python bindings: add gdal.enable_exceptions() context manager") in PR So: - remove this redundant gdal/ogr/osr.enable_exceptions() - remove gdaltest/ogrtest.enable_exceptions() - use ContextMgr() instead - and make its useExceptions argument default to True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the state of using exceptions to be set/reset locally, within a Python
withstatementThe Python gdal/ogr/osr/gnm modules each have a global state flag determining whether or not errors raise Exceptions. It defaults to not, and can be set or unset. However, because this is global, conflicts can arise in what a section of code requires, sometimes in code from other libraries. To avoid interfering with other code, one often needs to save current state, set desired state, perform some actions, then reset to saved state.
This PR adds a Python Context Manager class which handles this process, so that a Python
withstatement can have a desired state within that block, and not interact with the global state.It is added to the generic
python_exceptions.iSWIG code, so it appears in each of the different GDAL modules.