Zarr: update V3 format to latest specification #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n some circumstances
…es ZarrGroupVx to ZarrVXGroup (no functional change)
elpaso
approved these changes
May 8, 2023
There was a problem hiding this comment.
I am not familiar with the format but this LGTM.
My only concern is about the rename operations implementations of the various objects, it seems to me there is quite a lot of similar or identical code: would it be possible to use a template or an abstract base class to reduce duplicated code?
…ty), but without codec/compression support for now
…er larger than needed
… a NotifyChildrenOfRenaming() virtual method
I've tried to reduce amount of copied&pasted code in c81d12f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7637.
On top of PR #7684. only commits starting with "Zarr: move code belonging to classes to dedicated files" belong to this PR
This breaks backwards / upwards compatibility with previous GDAL versions: Zarr V3 datasets generated by GDAL < 3.8 can't be read by GDAL >= 3.8dev, and ZarrV3 datasets generated by GDAL >= 3.8dev can't be read by GDAL < 3.8