i.sentinel.coverage: update module to be compatible with the i.sentinel.download EODAG migration #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamedElgizery
force-pushed
the
sentinel_coverage_download_comp
branch
from
d81fe50 to
838fd92
Compare
veroandreo
reviewed
Aug 28, 2024
| quiet=True, | ||
| ) | ||
| columns_dict = grass.parse_command("v.info", map=temp_overlay, flags="c") | ||
| drop_columns = [ | ||
| col.split("|")[1] | ||
| for col in columns_dict | ||
| if col.split("|")[1] not in ["cat", "identifier"] | ||
| if col.split("|")[1] | ||
| not in ["cat", "title"] # What does cat refer to here? |
There was a problem hiding this comment.
cat is the geometry identifier in GRASS vector maps, so, like the id in other formats
HamedElgizery
force-pushed
the
sentinel_coverage_download_comp
branch
from
008ac5b to
75e0f92
Compare
|
Hello @veroandreo, sorry for the late follow up here. There have been a problem with EODAG < 3.0.0... The results of searching wasn't consistent, as if you were to do the same searching query twice, the resulting scenes could vary, and that was causing troubles with i.sentinel.coverage. But, it is fixed now with EODAG 3, and the module works fine now. I will add a check to make sure that the version of EODAG installed is > 3.0.0 here. (and within i.sentinel.download in another PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the i.sentinel.download migration to the EODAG API, multiple changes are needed to make i.sentinel.coverage compatible. The main problem was because the key referring to the scenes' files names are changed from identifier to title
This PR will also fix the example of using the name option, by omitting the clouds option, and by removing the exclusivity relation between the names and the producttype options.