refactored dialogs.py v2

OSGeo · Sep 25, 2024 · 7c2b4bb · 7c2b4bb
1 parent 68c7245
commit 7c2b4bb
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/gui/wxpython/dbmgr/dialogs.py b/gui/wxpython/dbmgr/dialogs.py
@@ -222,10 +222,13 @@ def GetSQLString(self, updateValues=False):
                     ctype = columns[name]["ctype"]
                     value = columns[name]["values"][idx]
                     id = columns[name]["ids"][idx]
-                    try:
-                        newvalue = self.FindWindowById(id).GetValue()
-                    except:
-                        newvalue = self.FindWindowById(id).GetLabel()
+                    widget = self.FindWindowById(id)
+                    if hasattr(widget, "GetValue"):
+                        newvalue = widget.GetValue()
+                    elif hasattr(widget, "GetLabel"):
+                        newvalue = widget.GetLabel()
+                    else:
+                        raise AttributeError(f"AttributeError in {widget}")
 
                     if newvalue:
                         try: