wxGUI: Fixed F841 in iscatt/ (#4432)

* fixed all F841

* updated flake8

* reverted add_callback

* Update plots.py

.flake8

@@ -27,7 +27,6 @@ per-file-ignores =
     gui/scripts/d.wms.py: E501
     gui/wxpython/image2target/*: F841, E722
     gui/wxpython/image2target/g.gui.image2target.py: E501, F841
-    gui/wxpython/iscatt/*: F841
     gui/wxpython/lmgr/frame.py: F841, E722
     # layertree still includes some formatting issues (it is ignored by Black)
     gui/wxpython/lmgr/layertree.py: E722, E266, W504, E225

gui/wxpython/iscatt/controllers.py

@@ -192,9 +192,7 @@ def SetDataDone(self, event):
         del self.busy
         self.data_set = True
 
-        todo = event.ret
         self.bad_bands = event.ret
-        bands = self.core.GetBands()
 
         self.bad_rasts = event.ret
         self.cats_mgr.SetData()
@@ -809,7 +807,6 @@ def ExportCatRast(self, cat_id):
     def OnExportCatRastDone(self, event):
         ret, err = event.ret
         if ret == 0:
-            cat_attrs = self.GetCategoryAttrs(event.kwds["cat_id"])
             GMessage(
                 _("Scatter plot raster of class <%s> exported to raster map <%s>.")
                 % (event.userdata["name"], event.kwds["rast_name"])

gui/wxpython/iscatt/plots.py

@@ -255,7 +255,6 @@ def Plot(self, cats_order, scatts, ellipses, styles):
             if not e:
                 continue
 
-            colors = styles[cat_id]["color"].split(":")
             if self.transpose:
                 e["theta"] = 360 - e["theta"] + 90
                 if e["theta"] >= 360:
@@ -355,9 +354,6 @@ def ZoomRectangle(self, event):
         if event.button != 1:
             return
 
-        cur_xlim = self.axes.get_xlim()
-        cur_ylim = self.axes.get_ylim()
-
         x1, y1 = event.xdata, event.ydata
         x2 = deepcopy(self.zoom_rect_coords["x"])
         y2 = deepcopy(self.zoom_rect_coords["y"])
@@ -651,13 +647,11 @@ def __init__(self, ax, pol, empty_pol):
 
         x, y = zip(*self.pol.xy)
 
-        style = self._getPolygonStyle()
-
         self.line = Line2D(x, y, marker="o", markerfacecolor="r", animated=True)
         self.ax.add_line(self.line)
         # self._update_line(pol)
 
-        cid = self.pol.add_callback(self.poly_changed)
+        self.pol.add_callback(self.poly_changed)
         self.moving_ver_idx = None  # the active vert
 
         self.mode = None