Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of bands relevant only to strds #1447

Merged
merged 4 commits into from
Mar 21, 2021
Merged

Number of bands relevant only to strds #1447

merged 4 commits into from
Mar 21, 2021

Conversation

landam
Copy link
Member

@landam landam commented Mar 11, 2021

This PR fixes issue reported in #1342

Steps to reproduce the bug:

t.create A01 type=str3ds title=x d=y

fails with

Traceback (most recent call last):
  File "/home/martin/src/grass/dist.x86_64-pc-linux-gnu/scripts/t.create", line 94, in <module>
    main()
  File "/home/martin/src/grass/dist.x86_64-pc-linux-gnu/scripts/t.create", line 87, in main
ERROR: Unable to execute transaction:
...
sqlite3.OperationalError: table str3ds_metadata has no column named number_of_bands

By applying this PR its possible to create all stds:

t.create A02 type=str3ds title=x d=y
t.create A02 type=strds title=x d=y
t.create A02 type=stvds title=x d=y

Property number of bands is relevant only to strds:

t.info A02
...
 | Number of registered bands:. None
...

@landam landam linked an issue Mar 11, 2021 that may be closed by this pull request
[Bug] Many tests fail with issues related to band references #1342
Closed
@landam landam added this to the 8.0.0 milestone Mar 11, 2021
@landam landam added blocker Blocking a release bug Something isn't working labels Mar 11, 2021
@landam landam self-assigned this Mar 11, 2021
This was referenced Mar 11, 2021
Merged
Closed
wenzeslaus
wenzeslaus requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and it brings the tests above 90%. Perhaps a test for for these combinations is missing in the first place.

Do you want to go ahead and change --min-success 80 to 90? (The two Ubuntu tests are at 91% and 92% in this PR.)

@wenzeslaus
Copy link
Member

Just to be clear about the impact: This fixes 11 tests according to a rough comparison between current master branch and this PR.

  Numbers for Ubuntu 18.04
- From them 213 files (87%) were successful and 33 files (13%) failed.
+ From them 224 files (91%) were successful and 22 files (9%) failed.

@landam landam requested a review from wenzeslaus March 19, 2021 20:29
@landam landam merged commit 7df1a7e into OSGeo:master Mar 21, 2021
@landam landam deleted the number_of_bands_issue_1342 branch March 21, 2021 22:02
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@landam @ninsbl
Number of bands relevant only to strds (OSGeo#1447)
0c203ec 
* number of bands is relevant only for strds
* sync print_info()/print_shell_info(): print properties in the same order
* OOP design improved
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@landam @ninsbl
Number of bands relevant only to strds (OSGeo#1447)
41d773e 
* number of bands is relevant only for strds
* sync print_info()/print_shell_info(): print properties in the same order
* OOP design improved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@veroandreo veroandreo veroandreo approved these changes

@neteler neteler Awaiting requested review from neteler

Assignees

@landam landam

Labels
blocker Blocking a release bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Many tests fail with issues related to band references
3 participants
@landam @wenzeslaus @veroandreo