-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/settings: fix hiding 'Tools' tab for single-window mode #2460
Merged
tmszi
merged 2 commits into
OSGeo:main
from
tmszi:wxgui_settings_fix_single_win_mode_hide_tools_tab
Jul 19, 2022
Merged
wxGUI/settings: fix hiding 'Tools' tab for single-window mode #2460
tmszi
merged 2 commits into
OSGeo:main
from
tmszi:wxgui_settings_fix_single_win_mode_hide_tools_tab
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, although it is probably more a workaround than a real fix. I just added a small suggestion to fix the variable naming for clarity
gui/wxpython/main_window/frame.py
Outdated
Comment on lines
676
to
678
notebook = self._auimgr.GetNotebooks() | ||
if notebook: | ||
notebook = notebook[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
notebook = self._auimgr.GetNotebooks() | |
if notebook: | |
notebook = notebook[0] | |
notebooks = self._auimgr.GetNotebooks() | |
if notebooks: | |
notebook = notebooks[0] |
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jul 19, 2022
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Jul 19, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
When you check checkbox widget Hide 'Tools' tab (wxGUI settings dialog) for single-window mode, wxGUI doesn't launch.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When you check checkbox widget Hide 'Tools' tab (wxGUI settings dialog) for single-window mode, wxGUI should be launch without error.
System description (please complete the following information):