Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI/modules: fix import PostGIS geometry data #2490

Merged
merged 2 commits into from
Oct 24, 2022
Merged

wxGUI/modules: fix import PostGIS geometry data #2490

merged 2 commits into from
Oct 24, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jul 21, 2022

Describe the bug
Import PostGIS geometry data via wxGUI Import vector data dialog doesn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI
  2. Set PostGIS connection via db.login module
  3. From the Data catalog toolbar activate Import vector data tool
  4. From the Import vector data dialog Source type choose Database RadioButton widget
  5. Format ComboBox widget is not active

Expected behavior
Import PostGIS geometry data via wxGUI Import vector data dialog should be work.

Screenshots
wxgui_import_dialog_def

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all
  • ogr2ogr --version: GDAL 3.4.2, released 2022/03/08

Additional context

GRASS nc_basic_spm_grass7/PERMANENT:~ > v.in.ogr -f | grep Postgre
Supported formats:
 PostgreSQL (rw+): PostgreSQL/PostGIS
 PGDUMP (rw+): PostgreSQL SQL dump

@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Jul 21, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jul 21, 2022
@tmszi tmszi mentioned this pull request Aug 28, 2022
Merged
@tmszi tmszi force-pushed the wxgui-ogr_import_dialog-fix-import-pg-geom-data branch from 3b876d2 to 2a5f101 Compare August 29, 2022 14:28
@tmszi
Copy link
Member Author

tmszi commented Aug 29, 2022

Rebase 2a5f101.

@tmszi tmszi requested a review from petrasovaa October 9, 2022 04:37
petrasovaa
petrasovaa approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test, but it looks fine.

@tmszi tmszi merged commit c5630fb into OSGeo:main Oct 24, 2022
tmszi added a commit that referenced this pull request Oct 24, 2022
@tmszi
wxGUI/modules: fix import PostGIS geometry data (#2490)
5e305af
@tmszi tmszi deleted the wxgui-ogr_import_dialog-fix-import-pg-geom-data branch October 24, 2022 19:16
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@tmszi @ninsbl
wxGUI/modules: fix import PostGIS geometry data (OSGeo#2490)
de1dcc9
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
@tmszi @marisn
wxGUI/modules: fix import PostGIS geometry data (OSGeo#2490)
86d0e79
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@tmszi @neteler
wxGUI/modules: fix import PostGIS geometry data (OSGeo#2490)
07a7eb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler left review comments

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmszi @neteler @petrasovaa