Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: fix display of all single window mode main toolbar tools #2617

Merged
merged 1 commit into from
Oct 31, 2022
Merged

wxGUI: fix display of all single window mode main toolbar tools #2617

merged 1 commit into from
Oct 31, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Oct 29, 2022 •
edited
Loading

Current main toolbar tools layout (some tools are hidden):

wxgui_main_toolbars_tool_current

Expected main toolbar tools layout:

wxgui_main_toolbars_tool_expected

  • Operating System: MS Windows, macOS
  • GRASS GIS version: 8.3.dev

Additional context

Another solution is to set margins after this line:

grass/gui/wxpython/gui_core/toolbars.py

Line 392 in c492ae5

super().__init__( 

if platform.system() in ("Windows", "Darwin"):
    self.SetMargins(8, 8)

#2568

@tmszi tmszi added bug Something isn't working backport_needed windows Microsoft Windows specific GUI wxGUI related macOS macOS specific labels Oct 29, 2022
@tmszi tmszi added this to the 8.3.0 milestone Oct 29, 2022
petrasovaa
petrasovaa approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it, it's rather weird issue. This solution seems fine.

@tmszi
Copy link
Member Author

tmszi commented Oct 31, 2022 •
edited
Loading

Another solution is use agwStyle wx.aui.AUI_TB_DEFAULT_STYLE only. But background toolbar color is gradient.

nilason
nilason approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. Thank you!

@tmszi tmszi merged commit daaf4cb into OSGeo:main Oct 31, 2022
@tmszi tmszi deleted the fix-show-all-aui-toolbar-tools branch October 31, 2022 18:40
@petrasovaa petrasovaa mentioned this pull request Nov 7, 2022
Merged
petrasovaa pushed a commit that referenced this pull request Nov 11, 2022
@tmszi @petrasovaa
wxGUI: fix display of all single window mode main toolbar tools (#2617)
004df20 
On the MS Windows and macOS platform.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@tmszi @ninsbl
wxGUI: fix display of all single window mode main toolbar tools (OSGe…
1f2a22c 
…o#2617)

On the MS Windows and macOS platform.
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
@tmszi @marisn
wxGUI: fix display of all single window mode main toolbar tools (OSGe…
e23de8d 
…o#2617)

On the MS Windows and macOS platform.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@tmszi @neteler
wxGUI: fix display of all single window mode main toolbar tools (OSGe…
90a79e4 
…o#2617)

On the MS Windows and macOS platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

@nilason nilason nilason approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related macOS macOS specific windows Microsoft Windows specific
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tmszi @petrasovaa @nilason