Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.patch: disable parallelization when MASK is active #2829

Merged
merged 2 commits into from
Feb 17, 2023
Merged

r.patch: disable parallelization when MASK is active #2829

merged 2 commits into from
Feb 17, 2023

Conversation

petrasovaa
Copy link
Contributor

Reading rasters in parallel when MASK is active leads to errors, see #2809. This PR disables parallelization when MASK is in use.

@petrasovaa petrasovaa added bug Something isn't working C Related code is in C labels Feb 14, 2023
@petrasovaa petrasovaa added this to the 8.3.0 milestone Feb 14, 2023
nilason
nilason approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the lightning strikes me, we can always remove this in time for 8.3. Please go ahead.

(I suppose there is no simple boolean function to query if mask is active?)

@petrasovaa
Copy link
Contributor Author

(I suppose there is no simple boolean function to query if mask is active?)

Not really, this is used in other modules. Vashek has an unfinished PR related to this: #2390

@nilason nilason mentioned this pull request Feb 17, 2023
Closed
@petrasovaa petrasovaa merged commit 9e17b9e into OSGeo:main Feb 17, 2023
@petrasovaa petrasovaa deleted the r.patch-disable-parallel-mask branch February 17, 2023 14:07
petrasovaa added a commit that referenced this pull request Feb 17, 2023
@petrasovaa
r.patch: disable parallelization when MASK is active (#2829)
70796b5
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@petrasovaa @ninsbl
r.patch: disable parallelization when MASK is active (OSGeo#2829)
7fa2014
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@petrasovaa @neteler
r.patch: disable parallelization when MASK is active (OSGeo#2829)
582b163
@petrasovaa petrasovaa mentioned this pull request Apr 5, 2024
Merged
@wenzeslaus
Copy link
Member

(I suppose there is no simple boolean function to query if mask is active?)

There is now and was applied in #4402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilason nilason nilason approved these changes

@wenzeslaus wenzeslaus wenzeslaus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working C Related code is in C
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@petrasovaa @wenzeslaus @nilason