Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks: Fix -Winvalid-utf8 compiler warning #2873

Merged
merged 3 commits into from
Mar 17, 2023
Merged

checks: Fix -Winvalid-utf8 compiler warning #2873

merged 3 commits into from
Mar 17, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Mar 6, 2023

No description provided.

@nilason nilason added enhancement New feature or request C Related code is in C labels Mar 6, 2023
@nilason nilason added this to the 8.3.0 milestone Mar 6, 2023
@nilason nilason mentioned this pull request Mar 6, 2023
Closed
wenzeslaus
wenzeslaus reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong. The previous code is correctly interpreted on GitHub, the new one is not.

Screenshot from 2023-03-10 16-25-24

@nilason
Copy link
Contributor Author

nilason commented Mar 10, 2023

Something is wrong. The previous code is correctly interpreted on GitHub, the new one is not.

It may be online glitch, see “view file” https://github.com/OSGeo/grass/blob/8bcfc3ed8c14452f38f9e4a315fc2738861365fb/imagery/i.atcorr/computations.cpp. I did notice this though and planned to take a proper new look at this. Perhaps best to change to simple “e”.

@nilason
Copy link
Contributor Author

nilason commented Mar 17, 2023

Something is wrong. The previous code is correctly interpreted on GitHub, the new one is not.

It may be online glitch, see “view file” https://github.com/OSGeo/grass/blob/8bcfc3ed8c14452f38f9e4a315fc2738861365fb/imagery/i.atcorr/computations.cpp. I did notice this though and planned to take a proper new look at this. Perhaps best to change to simple “e”.

No need to complicate matters, no need for for the accented e in an in-line comment. I had no problem finding the referenced literature anyway. I changed the é to a simple e, thus the file is ascii formatted.

This was referenced Mar 17, 2023
Merged
Closed
@nilason nilason merged commit 29609fa into OSGeo:main Mar 17, 2023
@nilason nilason deleted the 02_ped_-Winvalid-utf8 branch March 19, 2023 08:00
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Mar 20, 2023
@nilason @ninsbl
i.atcorr: Fix -Winvalid-utf8 compiler warning (OSGeo#2873)
c0866d1
@neteler neteler changed the title Fix -Winvalid-utf8 compiler warning checks: Fix -Winvalid-utf8 compiler warning Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@nilason @neteler
i.atcorr: Fix -Winvalid-utf8 compiler warning (OSGeo#2873)
23285f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus left review comments

Assignees
No one assigned
Labels
C Related code is in C enhancement New feature or request
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nilason @wenzeslaus