-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.proj: Fix -Wembedded-directive compiler warnings #2877
Conversation
"warning: embedding a directive within macro arguments has undefined behavior"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctly me if I'm mistaken, but this not only addresses a compiler warning, but it also fixes the strings for translation which cannot be constructed using using ifdefs or ifs.
It seems to me in this case it worked as it should, in spite of the warnings, example taken from main: #: ../general/g.proj/main.c:113
msgid ""
"Print 'flat' output with no linebreaks (applies to WKT and PROJ.4 output)"
msgstr "Ausgabe ohne Zeilenumbrüche (nur bei WKT- und PROJ.4-Ausgaben)"
#: ../general/g.proj/main.c:319
#, c-format
msgid "Only one of -%c, -%c, -%c, -%c, -%c or -%c flags may be specified"
msgstr ""
"Nur ein Schalter von -%c, -%c, -%c, -%c, -%c oder -%c kann angegeben werden"
Either way, there is no translation for the case of |
On the other hand, this is not an exceptional situation. There are lots of "missing" translatable messages for different states (compiled with this or that etc.). |
Addresses warnings with the description: "warning: embedding a directive within macro arguments has undefined behavior"
Addresses warnings with the description: "warning: embedding a directive within macro arguments has undefined behavior"
Addresses warnings with the description: