Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deps): Update actions/checkout action to v4 #3138

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 4, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/checkout action major v3 -> v4

Release Notes

actions/checkout (actions/checkout)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@neteler neteler merged commit fe03fbb into main Sep 4, 2023
@renovate renovate bot deleted the renovate/actions-checkout-4.x branch September 4, 2023 18:26
@tmszi
Copy link
Member

tmszi commented Sep 5, 2023

According error message it seems NodeJS version v20.x.x require newer glibc lib version 2.25 than default 2.17 under CentOS CI.

/usr/bin/docker exec  aa1dddd86fe251e57da64f8b5212cbf5115eb79c517b931e91e6fad0ad0031e9 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)

CentOS Linux 7 EOL: 2024-06-30

@wenzeslaus
Copy link
Member

I'm fine with dropping the CentOS 7 check, but make a PR to remove it. The CentOS 7 check now fails on the main branch and it did fail here in this PR.

@tmszi
Copy link
Member

tmszi commented Sep 5, 2023

Maybe we can try override Node.js version with actions/setup-node@v3

jobs:
  build:
    name: ${{ matrix.os }} build

    runs-on: ubuntu-22.04
    container: ${{ matrix.os }}
    strategy:
      matrix:
        os:
          - centos:7
      fail-fast: false

    steps:
      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
      - uses: actions/setup-node@v3
        with:
          node-version: '12'      

neteler added a commit to neteler/grass that referenced this pull request Sep 6, 2023
Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see OSGeo#3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).
@neteler
Copy link
Member

neteler commented Sep 6, 2023

I'm fine with dropping the CentOS 7 check, but make a PR to remove it.

Done in #3141

neteler added a commit that referenced this pull request Sep 7, 2023
Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see #3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
@neteler neteler added this to the 8.4.0 milestone Sep 12, 2023
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see OSGeo#3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see OSGeo#3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
nilason pushed a commit to nilason/grass that referenced this pull request Apr 23, 2024
Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see OSGeo#3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
nilason pushed a commit to nilason/grass that referenced this pull request Apr 23, 2024
Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see OSGeo#3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
nilason added a commit that referenced this pull request Apr 23, 2024
* CI: drop outdated CentOS 7 compilation (#3141)

Remove of CentOS 7 compilation as no longer compatible with new GHA checkout v4 (see #3138 - Background: default runtime now node20. Node16 has end of life on 11 Sep 2023).

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>

* windows: use Python 3.12 with updated OSGeo4W (#3603)

See: https://lists.osgeo.org/pipermail/grass-dev/2024-April/096269.html

---------

Co-authored-by: Markus Neteler <neteler@osgeo.org>
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants