Docker: Sync main Dockerfile to docker/ubuntu/Dockerfile #3205
Conversation
|
Thanks @echoix |
|
Travis failing is unexpected, it didn't fail up to yesterday, and it errors out at the https://github.com/OSGeo/grass/blob/0bc5039dd372684562b13f85ae087418a1add8a4/.travis/linux.before_install.sh file |
|
Failure of the Ubuntu minimum Test seems an unrelated, random time out of a temporal test. |
1 similar comment
|
Failure of the Ubuntu minimum Test seems an unrelated, random time out of a temporal test. |
See #3202 |
|
The Pylint failure, even if I'm certain that it's not this PR that caused it, intrigues me since there are still 111 failures and 180 passed, 98 deselected, and the three other steps didn't run (compiling example module and building and deploying sphinx doc) |
|
May we merge this PR? |
|
I hoped it would be merged last weekend ;) |
|
We are trapped: "Required statuses must pass before merging".. :( |
|
Do you want me to just temporarily ou the old version in this PR or a new one (which would have the additional checks failing)? |
|
I pinned the version of pytest-pylint like suggested by #3203 (comment) It should allow to pass the tests. The errors should still be fixed, they seem legitimate (by the looks of it without looking in a complete IDE). Thus I made sure to leave a note in the action in order to remove it very shortly after. Feel free to cherry pick the first commit only for back porting, or reverting anything else later. But it unlocks everybody else for now. |
echoix
changed the title
neteler
changed the title
wenzeslaus
changed the title
- Copies over the Ubuntu Dockerfile edited in OSGeo#3170 to the main Dockerfile in the root of the repo. - Adds a note at the top for future edits to the file (in both files). Additionally, this includes a temporary fix for pytest-pylint where new version finds more issues than the old one, so we need to use the old one before we fix the issues.
- Copies over the Ubuntu Dockerfile edited in OSGeo#3170 to the main Dockerfile in the root of the repo. - Adds a note at the top for future edits to the file (in both files). Additionally, this includes a temporary fix for pytest-pylint where new version finds more issues than the old one, so we need to use the old one before we fix the issues.
- Copies over the Ubuntu Dockerfile edited in OSGeo#3170 to the main Dockerfile in the root of the repo. - Adds a note at the top for future edits to the file (in both files). Additionally, this includes a temporary fix for pytest-pylint where new version finds more issues than the old one, so we need to use the old one before we fix the issues.
Closes #3204
I copied over the ubuntu dockerfile edited in #3170 to the dockerfile in the root of the repo, and added a note at the top for future edits to the file (in both files).
This should allow the additional checks to pass again.