Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.horizon: fix computation in test_low_res() #3298

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

petrasovaa
Copy link
Contributor

I found a potential error in test_low_res() function, that looks like a copy and paste error, see the variables used in the code above the fix. I don't really understand how that impacts results, the tests seem not affected.

@petrasovaa petrasovaa added bug Something isn't working raster Related to raster data processing C Related code is in C backport to 8.3 errata Include in errata (fixes wrongly computed results) labels Dec 13, 2023
@petrasovaa petrasovaa added this to the 8.4.0 milestone Dec 13, 2023
@petrasovaa petrasovaa requested a review from metzm December 13, 2023 15:51
@petrasovaa petrasovaa self-assigned this Dec 13, 2023
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"One of these things is not like the others."

@wenzeslaus wenzeslaus removed the request for review from metzm January 5, 2024 17:41
@github-actions github-actions bot added the module label Jan 5, 2024
@petrasovaa petrasovaa merged commit 04763fd into OSGeo:main Jan 5, 2024
23 checks passed
@petrasovaa petrasovaa deleted the r.horizon-fix-test_low_res branch January 5, 2024 21:11
@neteler neteler modified the milestones: 8.4.0, 8.3.2 Jan 6, 2024
petrasovaa added a commit to petrasovaa/grass that referenced this pull request Jan 8, 2024
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C Related code is in C errata Include in errata (fixes wrongly computed results) module raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants