Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update super-linter.yml to use super-linter/super-linter #3332

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Jan 5, 2024

Super-linter is now in its own organization since April 26th, 2023. This updates the workflow to use newer releases.

@github-actions github-actions bot added the CI Continuous integration label Jan 5, 2024
@echoix
Copy link
Member Author

echoix commented Jan 5, 2024

I’m not particularly a big fan of super-linter, the way it is can be configured, but I’m obviously biased since I’ve been collaborator and maintainer of MegaLinter for two years now, a project that had its roots in super-linter. But this workflow still obviously deserves to be maintained and updated, even if some further changes might do otherwise. It’s our « now » tool, so we need to keep it working correctly :)

@echoix
Copy link
Member Author

echoix commented Jan 5, 2024

I’ll come back with the fixes tomorrow, I remember fixing them in one of my exploratory branches, I just have to find them.

@echoix echoix force-pushed the super-linter-super-linter branch from 6de94da to 7a1e8fd Compare January 5, 2024 13:58
echoix added 2 commits January 5, 2024 14:00
Super-linter is now in its own organization since April 26th, 2023. This updates the workflow to use newer releases.
@echoix echoix force-pushed the super-linter-super-linter branch from 7a1e8fd to b41afdb Compare January 5, 2024 14:00
@echoix
Copy link
Member Author

echoix commented Jan 5, 2024

Ready to review

@github-actions github-actions bot added macOS macOS specific docs markdown labels Jan 5, 2024
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the update, but I'm a fan of MegaLinter!

@echoix
Copy link
Member Author

echoix commented Jan 5, 2024

+1 for the update, but I'm a fan of MegaLinter!

I thought the direction we were going was to use precommit ci (#3255)

I was holding off on optimizing the h*ll out of our linters, since the repo had another vision/direction that I respect and will play with. It is also the reason I didn't push further on #3284, and didn't complete it, since it wasn't really wanted, and the general attitude here is to have everything right the first time, thus waiting and leaving out smaller improvements, rather than continuously improve by small steps. Both opinions are justified, it only needs to get used to, and I respect both.

@echoix echoix merged commit e4a9cb9 into OSGeo:main Jan 6, 2024
24 checks passed
@echoix echoix deleted the super-linter-super-linter branch January 6, 2024 15:09
@wenzeslaus
Copy link
Member

+1 for the update, but I'm a fan of MegaLinter!

I thought the direction we were going was to use precommit ci (#3255)

I think there is a value in having multiple tools. One does not respect the settings (like Flake8 in pre-commit), another one is not used locally (usually true for MegaLinter, super-linter), ... Also when there is a problem with one, the other is still in place (we can disable one and continue, instead of completely migrating from one to another).

HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
* Update super-linter.yml to use super-linter/super-linter

Super-linter is now in its own organization since April 26th, 2023. This updates the workflow to use newer releases.

* Apply fixes to email links in markdown
@neteler neteler added this to the 8.4.0 milestone Jan 14, 2024
@neteler neteler changed the title Update super-linter.yml to use super-linter/super-linter CI: update super-linter.yml to use super-linter/super-linter Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration docs macOS macOS specific markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants