-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update super-linter.yml to use super-linter/super-linter #3332
Conversation
I’m not particularly a big fan of super-linter, the way it is can be configured, but I’m obviously biased since I’ve been collaborator and maintainer of MegaLinter for two years now, a project that had its roots in super-linter. But this workflow still obviously deserves to be maintained and updated, even if some further changes might do otherwise. It’s our « now » tool, so we need to keep it working correctly :) |
I’ll come back with the fixes tomorrow, I remember fixing them in one of my exploratory branches, I just have to find them. |
6de94da
to
7a1e8fd
Compare
Super-linter is now in its own organization since April 26th, 2023. This updates the workflow to use newer releases.
7a1e8fd
to
b41afdb
Compare
Ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the update, but I'm a fan of MegaLinter!
I thought the direction we were going was to use precommit ci (#3255) I was holding off on optimizing the h*ll out of our linters, since the repo had another vision/direction that I respect and will play with. It is also the reason I didn't push further on #3284, and didn't complete it, since it wasn't really wanted, and the general attitude here is to have everything right the first time, thus waiting and leaving out smaller improvements, rather than continuously improve by small steps. Both opinions are justified, it only needs to get used to, and I respect both. |
I think there is a value in having multiple tools. One does not respect the settings (like Flake8 in pre-commit), another one is not used locally (usually true for MegaLinter, super-linter), ... Also when there is a problem with one, the other is still in place (we can disable one and continue, instead of completely migrating from one to another). |
* Update super-linter.yml to use super-linter/super-linter Super-linter is now in its own organization since April 26th, 2023. This updates the workflow to use newer releases. * Apply fixes to email links in markdown
Super-linter is now in its own organization since April 26th, 2023. This updates the workflow to use newer releases.