-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update publishing workflow #3437
Conversation
This has also to be combined somehow with |
Updated this workflow to re-use (update) Now it also contains the This keeps the previous behaviour and adds the new release packages. Assets created:
|
This now fails because it is missing #3435. Se my bogus test release for result. |
Side note: The single use of https://github.com/softprops/action-gh-release replaces them and also the https://github.com/actions/upload-artifact. |
Was this ready and intended to be merged? I know we need to ignore the failure in the new workflow for now due to to missing parts |
Yes. As this now re-use the create_release_draft.yml workflow, Readme doesn't need to be updated (I believe). |
Is #3435 still a requirement? If so we could sprint it up a little |
Before merging this PR, it might need a new title, since it isn't a new workflow. Also, is the existing workflow file name still appropriate for what it now does? If ever it is changed, since the contents of the workflow changed a lot, maybe we would need a mini PR that renames the file before this PR is merged, to be able to follow the file history after renames. |
Generates Git derived data files, which are added to release tarballs of both `*.tar.gz` and `tar.xz` formats. Accompanied by `md5` and `sha256` checksum files.
c2db994
to
c29c96b
Compare
Done.
I think the file name is quite ok, reflecting what it does, no need to change. |
Generates Git derived data files, which are added to release tarballs of both
*.tar.gz
andtar.xz
formats. Accompanied bymd5
andsha256
checksum files.Solves #3430, depends on #3435.
Initially put up as draft, if this agreed upon the howto_release.md need to be updated.