Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.mkfontcap: Replace -o with --overwrite; Add a renamed flag warning #3649

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

HuidaeCho
Copy link
Member

This PR replaces -o with standard --overwrite and adds a warning.

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be the -o flag in several places:

./mswindows/osgeo4w/postinstall.bat
./mswindows/GRASS-Installer.nsi.tmpl
./lib/driver/font2.c
./binaryInstall.src

This should be probably replaced with --o, no?

@HuidaeCho
Copy link
Member Author

There seems to be the -o flag in several places:

./mswindows/osgeo4w/postinstall.bat ./mswindows/GRASS-Installer.nsi.tmpl ./lib/driver/font2.c ./binaryInstall.src

This should be probably replaced with --o, no?

Yes, better to do it now even though it's backward compatible.

@github-actions github-actions bot added the windows Microsoft Windows specific label Apr 23, 2024
@neteler neteler added this to the 8.4.0 milestone Apr 23, 2024
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there aren't missing places that also need this change, I agree with this!

@HuidaeCho
Copy link
Member Author

Assuming there aren't missing places that also need this change, I agree with this!

I couldn't find any other places than renamed_options using

$ find -type f ! -name '*.o' ! -name '*.so' ! -name '*.0dev' -exec grep -H 'g.mkfontcap.*[^-]-o' {} \; |
  grep -Ev '^./((bin|dist).x86_64-pc-linux-gnu|.git|build)'
./lib/gis/renamed_options:g.mkfontcap|-o:--overwrite

@HuidaeCho HuidaeCho merged commit 0b248ef into OSGeo:main Apr 23, 2024
26 checks passed
@HuidaeCho HuidaeCho deleted the g_mkfontcap_overwrite branch April 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C general libraries module windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants