Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix repeated-equality-comparison (PLR1714) #4042

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Jul 13, 2024

Ruff rule: https://docs.astral.sh/ruff/rules/repeated-equality-comparison/

Also applied PLR6201 (literal-membership) on these changes only, and will bring the fixes for the pre-existing PLR6201 issues. (I fixed PLR6201 before, committed, then fixed PLR1714, applied and checked PLR6201 again, committed, and at last dropped the first commit, and checked the results).

@echoix echoix added this to the 8.5.0 milestone Jul 13, 2024
@echoix echoix requested a review from ninsbl July 13, 2024 01:21
@github-actions github-actions bot added GUI wxGUI related vector Related to vector data processing temporal Related to temporal data processing Python Related code is in Python libraries module general tests Related to Test Suite labels Jul 13, 2024
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. My one comment is just a suggestion. Feel free to disregard if you prefer the original implementation...

python/grass/gunittest/gutils.py Show resolved Hide resolved
@echoix echoix merged commit 3b309db into OSGeo:main Jul 13, 2024
27 checks passed
@echoix echoix deleted the fix-repeated-equality-comparison branch July 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general GUI wxGUI related libraries module Python Related code is in Python temporal Related to temporal data processing tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants