style: Fix needless-bool (SIM103) #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the condition directly Ruff rule: https://docs.astral.sh/ruff/rules/needless-bool/ Added bool return type annotations when possible to confirm no other type was possible on changed functions
github-actions
bot
added
GUI
ninsbl
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Looks good in princple. Shortens and simplifies the code (reduces branches)...
I have some comments and suggestions for even further-reaching implementation.
But also here, you may have reasons to not include all possible changes... If so, I will approve after your reply...
ninsbl
reviewed
Jul 15, 2024
echoix
commented
Jul 15, 2024
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
|
Checked with ruff 0.5.4 and still passes. |
ninsbl
approved these changes
Jul 21, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
* style: Fix needless-bool (SIM103) Return the condition directly Ruff rule: https://docs.astral.sh/ruff/rules/needless-bool/ Added bool return type annotations when possible to confirm no other type was possible on changed functions * Update frame.py * Apply suggestions from code review Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com> * style: Merge more if conditions per review --------- Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the condition directly
Ruff rule: https://docs.astral.sh/ruff/rules/needless-bool/
Added bool return type annotations when possible to confirm no other type was possible on changed functions