-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.cluster: Fix unused value assignment #4094
Conversation
We're unsure about the intention behind including both 90% and 99% confidence intervals. Was there originally a plan to have an option between 90% and 99%? |
These would be good things to catch when revising the code. Perhaps all is needed is to create an issue for a (possibly?) straightforward addition (good for beginners). I'm tagging original author @metzm and @neteler who contributed to the documentation quite a bit. |
I would remove the duplicate eps lines and move on. |
I agree. The meaning of the constant literal is documented and the possibility of switch between 99% and 90% is obvious, so there is no added value in keeping that line or a comment in the code. |
Done removed the lines. so i guess it refers to the 99% confidence interval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Thanks for checking the documentation.
This pull request fixes the issue identified by coverity scan (CID: 1270389)
The variable eps gets overwritten so initially assigned value is commented.