grass.pygrass: remove unused arg in ctypes.CFUNCTYPE #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
reviewed
Jul 30, 2024
|
The reason for this to fail on the win runner only, could be the fact that that is the only one with Python 3.12. |
mshukuno
changed the title
nilason
changed the title
|
@echoix I have enabled auto-merge, if you agree with me this is good to go, just approve. |
|
I would only need to search the logs, this one, and just before, to see it fixed. I can't search on my phone, only scroll. So I'm checking soon ;) (unless someone finds the lines before). |
|
A run in main before this PR (after fixing trim of GEOS WKT output): https://github.com/OSGeo/grass/actions/runs/10217611481/job/28271801017#step:11:1483 |
echoix
approved these changes
Aug 2, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the comment here.
Initially, the PR was about fixing "ambiguous variable name 'l', but in this case 'l's were also unused so deletion was the initial fix. However, it appears Windows has a "ctypes" issue.
I would like to revert them as they were, but rename "l"s to avoid the E741 (Checks for the use of the characters 'l', 'O', or 'I' as variable names) issue. Since I couldn't figure out what "l" parameters are so I renamed it "l_what" for now. Let me know if you find appropriate variable name. Here is pygrass.raster package documentation.
However, the flake8 problem in F841 (unused-variable) will be addressed next, and noqa:F841 will be applied to them when I work on F841 problem.
I propose raising a separate issue if this needs to be investigated further since I don't have experience with C and "ctypes".
What do you think?