style: Fix non-augmented-assignment (PLR6104) #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good. What is the reason you left the last three out? |
echoix
commented
Aug 4, 2024
echoix
commented
Aug 4, 2024
|
Waiting for an approval |
ninsbl
approved these changes
Aug 10, 2024
landam
pushed a commit
to landam/grass
that referenced
this pull request
Aug 22, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/non-augmented-assignment/
93 instances fixed, 3 more to discuss (they will get a ruff suggestion comment, as I left them out for now)