lib: fix missing prototypes #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI
nilason
force-pushed
the
fix_strict_prototype
branch
from
df4bb2d to
dfd2910
Compare
|
Were the changes in the PR ready on their own? I just found multiple of these when looking at the failing macOS run in #4213, that would be fixed by this PR. |
|
Opening this for review. Proper fix for the BLAS/LAPACK is less than trivial, and I'm looking into that. Meanwhile a compiler suppression should suffice, preventing new cases like what happened recently with
This addresses those warnings and new warnings will cause failure. |
wenzeslaus
approved these changes
Aug 23, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
* r.report: add missing prototype * lib/db: add missing prototype * CI: fail macOS runner on -Wstrict-prototypes * lib/gmath: suppress -Wstrict-prototypes for BLAS/LAPACK wrapper header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address
-Wstrict-prototypeswarnings and make CI macOS runner fail in new cases.