Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.rectify: Fix copy into fixed size buffer issue in main.c of i.rectify module #4299

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

ShubhamDesai
Copy link
Contributor

This pull request resolves a buffer overflow issue detected by Coverity Scan (CID 1208277).
strcpy is replaced with G_strlcpy
The variable len is used to match the clang format check
The build was successful after the make process

@github-actions github-actions bot added C Related code is in C module imagery labels Sep 9, 2024
@nilason nilason added this to the 8.5.0 milestone Sep 11, 2024
echoix
echoix previously approved these changes Sep 11, 2024
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicking, but as you add a new include group, let us add an empty line between. This will (eventually) enable ClangFormat to sort includes without mixing the different groups.
Other than that, this is good to go.

Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
@ShubhamDesai
Copy link
Contributor Author

Sorry for nitpicking, but as you add a new include group, let us add an empty line between. This will (eventually) enable ClangFormat to sort includes without mixing the different groups. Other than that, this is good to go.

Done

@echoix echoix merged commit 95c123d into OSGeo:main Sep 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C imagery module
Projects
Development

Successfully merging this pull request may close these issues.

3 participants