v.to.3d: Fix Resource Leak Issue in trans2.c #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vector
added 2 commits
September 14, 2024 18:06
nilason
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses resource leak issue identified by coverity scan (CID: 1207898)
The function Vect_get_field() assigns a struct field_info object to Fi, which includes several dynamically allocated strings such as name, driver, database, table, and key. However, when Fi goes out of scope at the end of the function, the memory allocated for Fi and its strings isn't properly freed, causing a memory leak. To fix this, used existing function Vect_destroy_field_info(Fi) right after the database operations are completed and before the function exits. This ensures that all allocated memory is released, preventing the leak.