Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix default variable name for blas and lapack #4343

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Sep 19, 2024

Fix for bug in configuration of BLAS/LAPACK as revealed by Docker failures.

The problem was caused by a typo of the variable names with_blas and with_lapack.

In addition: improve handling of configuration with LAPACK without BLAS

In addition: improve handling of configuration with LAPACK
without BLAS
@nilason nilason added this to the 8.5.0 milestone Sep 19, 2024
@nilason nilason self-assigned this Sep 19, 2024
@nilason
Copy link
Contributor Author

nilason commented Sep 19, 2024

This will probably fix the Docker builds without blas/lapack.

For "Docker / build and push ubuntu " the likely solution is to add the package liblapacke-dev.

@nilason nilason merged commit a94c3b0 into OSGeo:main Sep 19, 2024
27 checks passed
@nilason nilason deleted the fix_configure_blas_lapack branch September 20, 2024 08:46
@echoix
Copy link
Member

echoix commented Sep 22, 2024

There's still the need to install the lapack in the Ubuntu Dockerfile, similar to what was added in the apt.txt file in grass-addons. 1 of the 4 docker images are constantly failing since the changes on the topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants