Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g.proj: Fix copy into fixed size buffer issue in input.c file #4359

Merged
merged 1 commit into from
Sep 21, 2024
Merged

g.proj: Fix copy into fixed size buffer issue in input.c file #4359

merged 1 commit into from
Sep 21, 2024

Conversation

ShubhamDesai
Copy link
Contributor

This pull request resolves a buffer overflow issue detected by Coverity Scan (CID 1501203).
strcpy is replaced with G_strlcpy.
The build was successful after the make process

@github-actions github-actions bot added C Related code is in C module general labels Sep 21, 2024
echoix
echoix approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the string should never appear unless there is an exceptional condition that would have been a bug before, and that it follows the same pattern of the other PRs, I think it's fine to go right away :)

@echoix echoix enabled auto-merge (squash) September 21, 2024 18:14
@echoix echoix merged commit d89ad9e into OSGeo:main Sep 21, 2024
26 checks passed
@neteler neteler modified the milestone: 8.5.0 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
C Related code is in C general module
Projects
GRASS GIS Security
Status: No status
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamDesai @echoix @neteler