Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add liblapacke-dev package to Ubuntu builds #4371

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Sep 23, 2024

The docker builds were still failing... So I took the liblapacke-dev package that was added to the apt.txt of the grass addons and added it into a list of packages in the Ubuntu build.

I just want someone to confirm I selected the correct list. I assumed it needed to be present for addons to compile with it.

@echoix echoix requested a review from nilason September 23, 2024 23:25
@github-actions github-actions bot added the docker Docker related label Sep 23, 2024
@echoix echoix changed the title docker: Add liblapacke-dev package to ubuntu builds docker: Add liblapacke-dev package to Ubuntu builds Sep 23, 2024
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenzeslaus wenzeslaus removed the request for review from nilason September 24, 2024 00:55
@wenzeslaus wenzeslaus merged commit c593eb0 into OSGeo:main Sep 24, 2024
27 checks passed
@echoix
Copy link
Member Author

echoix commented Sep 24, 2024

Oh, I see in there that it removed libooenblas-dev and added liblapacke-dev. Did this PR do the right thing? It build locally just fine at least

@wenzeslaus
Copy link
Member

Oh well, how did I miss that difference in the difference? Yes, the OpenBLAS should have been removed. It will work though.

@wenzeslaus
Copy link
Member

Whoever worked on the Docker images lately, @a-detiste @neteler @mmacata @anikaweinmann, my question what about the other images? The BLAS/LAPACK seems to be only in the main Ubuntu image, but it is not in wxGUI one, Debian or Alpine. Perhaps intentional for some but not the others?

@neteler
Copy link
Member

neteler commented Sep 24, 2024

I'm not aware of any intention. Guess it should be streamlined.

@nilason
Copy link
Contributor

nilason commented Sep 24, 2024

The libopenblas-dev package could be removed if it adds to the Docker size.

@echoix
Copy link
Member Author

echoix commented Sep 24, 2024

It should have an impact, but there are some global optimizations that could still be done too. I think openblas is in other Dockerfiles too, but it didn't complain yet.

@neteler neteler added this to the 8.5.0 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants