Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass.jupyter: fix interactivemap tests #4379

Merged
merged 1 commit into from
Sep 25, 2024
Merged

grass.jupyter: fix interactivemap tests #4379

merged 1 commit into from
Sep 25, 2024

Conversation

petrasovaa
Copy link
Contributor

@petrasovaa petrasovaa added this to the 8.5.0 milestone Sep 24, 2024
@petrasovaa petrasovaa requested a review from echoix September 24, 2024 18:16
@github-actions github-actions bot added Python Related code is in Python libraries tests Related to Test Suite notebook labels Sep 24, 2024
echoix
echoix approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow very well what's different to have the other test fixed, but I feel like the best way to know is to go ahead and update the other PR.

@petrasovaa
Copy link
Contributor Author

Sorry for not giving enough context. Since the tests are being skipped because of no ipyleaflet installed, I forgot to update the tests after rewriting the InteractiveMap methods.

@petrasovaa petrasovaa merged commit d99d840 into OSGeo:main Sep 25, 2024
26 checks passed
@echoix
Copy link
Member

echoix commented Sep 25, 2024

Sorry for not giving enough context. Since the tests are being skipped because of no ipyleaflet installed, I forgot to update the tests after rewriting the InteractiveMap methods.

So it's a good thing to have the optional requirements in the "full" config!

@neteler neteler modified the milestone: 8.5.0 Sep 25, 2024
@petrasovaa petrasovaa deleted the fix-jupyter-tests branch September 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
libraries notebook Python Related code is in Python tests Related to Test Suite
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@petrasovaa @echoix @neteler