lib/shapelib: sync upstream with shapelib 1.6.0 and GDAL 3.9.2

[nilason]

Sync external library shapelib with upstream shapelib 1.6.0 and GDAL 3.9.2.

[nilason]

Before we merge this, I was hoping to revisit the issue of the patch:

--- a/lib/external/shapelib/dbfopen.c
+++ b/lib/external/shapelib/dbfopen.c
@@ -1226,9 +1226,10 @@ DBFGetFieldInfo( DBFHandle psDBF, int iField, char * pszFieldName,
     else if( psDBF->pachFieldType[iField] == 'N'
              || psDBF->pachFieldType[iField] == 'F' )
     {
-    if( psDBF->panFieldDecimals[iField] > 0
-            || psDBF->panFieldSize[iField] >= 10 )
+    if( psDBF->panFieldDecimals[iField] > 0 ) {
+        /* || psDBF->panFieldSize[iField] >= 10 ) */ /* GDAL bug #809 */
         return( FTDouble );
+    }
     else
         return( FTInteger );
     }

(https://github.com/OSGeo/grass/tree/main/lib/external/shapelib#full-fix)

solving the very old issue of http://trac.osgeo.org/gdal/ticket/809

Is that patch really needed? If so, how to reproduce it?

[neteler]

solving the very old issue of http://trac.osgeo.org/gdal/ticket/809

(from the end of the ticket)

This ticket was incorporated into https://trac.osgeo.org/gdal/ticket/3615 which eventually led to https://gdal.org/en/latest/development/rfc/rfc31_ogr_64.html

I assume that the improvements also became part of SHAPElib.

[nilason]

solving the very old issue of http://trac.osgeo.org/gdal/ticket/809

(from the end of the ticket)

This ticket was incorporated into https://trac.osgeo.org/gdal/ticket/3615 which eventually led to https://gdal.org/en/latest/development/rfc/rfc31_ogr_64.html

I assume that the improvements also became part of SHAPElib.

I did see that, which is the reason I raised this issue. If that was a GDAL/shapelib specific issue at that time, I believe we can presume it has been solved by now.

I removed the patch (sorry @wenzeslaus :), only a small fix from shapelib 1.6.1 is taken to enable the Win CI runner.

I have no further plans with this PR.