Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.colors: Fix resource leak issue in scan_attr.c file #4423

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

ShubhamDesai
Copy link
Contributor

This pull request addresses resource leak issue identified by coverity scan (CID : 1207685)
Used existing function Vect_destroy_field_info() to fix the memory leak issue.

@github-actions github-actions bot added vector Related to vector data processing C Related code is in C module labels Oct 1, 2024
@echoix
Copy link
Member

echoix commented Oct 1, 2024

@nilason What do we (I) have to check with these kind of PRs? When does it apply, when should it NOT be used? What should I look for of "missing" changes that should also be part of a PR? Are there other gotchas to be aware of?

I'm also trying to learn this, there's been a couple of similar PRs recently, and didn't have a clue on what to look for. Every info/knowledge that I'd get I can use for future PRs when I do my screening (when I can), so I can weed out the easy issues and keep you and other for more advanced/specialized questions.

@nilason
Copy link
Contributor

nilason commented Oct 2, 2024

@nilason What do we (I) have to check with these kind of PRs? When does it apply, when should it NOT be used? What should I look for of "missing" changes that should also be part of a PR? Are there other gotchas to be aware of?

I'm also trying to learn this, there's been a couple of similar PRs recently, and didn't have a clue on what to look for. Every info/knowledge that I'd get I can use for future PRs when I do my screening (when I can), so I can weed out the easy issues and keep you and other for more advanced/specialized questions.

It’s terribly difficult to give you a general advice. Sorry :)

@echoix echoix added this to the 8.5.0 milestone Oct 3, 2024
@echoix echoix merged commit a4d3cea into OSGeo:main Oct 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C module vector Related to vector data processing
Projects
Development

Successfully merging this pull request may close these issues.

3 participants