wxGUI: Fixed E722 in frame.py

gui/wxpython/lmgr/frame.py

@@ -271,7 +271,7 @@ def show_menu_errors(messages):
                     y = client_disp[1]
                 self.SetPosition((x, y))
                 self.SetSize((w, h))
-            except:
+            except (ValueError, IndexError):
                 pass
         else:
             # does center (of screen) make sense for lmgr?
@@ -885,7 +885,7 @@ def OnCBPageChanged(self, event):
         try:
             self.GetMapDisplay().SetFocus()
             self.GetMapDisplay().Raise()
-        except:
+        except AttributeError:
             pass
 
         event.Skip()
@@ -1125,7 +1125,7 @@ def GetMenuCmd(self, event):
 
         try:
             cmdlist = cmd.split(" ")
-        except:  # already list?
+        except AttributeError:  # already list?
             cmdlist = cmd
 
         # check list of dummy commands for GUI modules that do not have GRASS
@@ -1137,7 +1137,7 @@ def GetMenuCmd(self, event):
             layer = self.GetLayerTree().layer_selected
             name = self.GetLayerTree().GetLayerInfo(layer, key="maplayer").name
             type = self.GetLayerTree().GetLayerInfo(layer, key="type")
-        except:
+        except AttributeError:
             layer = None
 
         if layer and len(cmdlist) == 1:  # only if no parameters given
@@ -1185,7 +1185,7 @@ def OnVDigit(self, event):
         # available only for vector map layers
         try:
             mapLayer = tree.GetLayerInfo(layer, key="maplayer")
-        except:
+        except AttributeError:
             mapLayer = None
 
         if not mapLayer or mapLayer.GetType() != "vector":
@@ -1862,7 +1862,7 @@ def OnShowAttributeTable(self, event, selection=None):
         # available only for vector map layers
         try:
             maptype = tree.GetLayerInfo(layer, key="maplayer").type
-        except:
+        except (AttributeError, KeyError):
             maptype = None
 
         if not maptype or maptype != "vector":

gui/wxpython/lmgr/layertree.py

@@ -756,7 +756,7 @@ def OnLayerContextMenu(self, event):
                     # self.popupMenu.Enable(self.popupID['bgmap'],  False)
                     self.popupMenu.Enable(self.popupID["topo"], False)
                 # else:
-                ###    self.popupMenu.Enable(self.popupID['bgmap'], True)
+                #    self.popupMenu.Enable(self.popupID['bgmap'], True)
 
             item = wx.MenuItem(
                 self.popupMenu, id=self.popupID["meta"], text=_("Metadata")
@@ -1742,7 +1742,7 @@ def OnDeleteLayer(self, event):
 
         try:
             item.properties.Close(True)
-        except:
+        except Exception:
             pass
 
         if item != self.root:
@@ -1758,7 +1758,7 @@ def OnDeleteLayer(self, event):
         try:
             if self.GetLayerInfo(item, key="type") != "group":
                 self.Map.DeleteLayer(self.GetLayerInfo(item, key="maplayer"))
-        except:
+        except (AttributeError, KeyError):
             pass
 
         # redraw map if auto-rendering is enabled
@@ -1999,7 +1999,7 @@ def OnDrop(self, dropTarget, dragItem):
         # save everything associated with item to drag
         try:
             old = dragItem  # make sure this member exists
-        except:
+        except Exception:
             return
 
         Debug.msg(4, "LayerTree.OnDrop(): layer=%s" % (self.GetItemText(dragItem)))
@@ -2046,7 +2046,7 @@ def RecreateItem(self, dragItem, dropTarget, parent=None):
                 newctrl.SetValue(
                     self.GetLayerInfo(dragItem, key="maplayer").GetCmd(string=True)
                 )
-            except:
+            except Exception:
                 pass
             newctrl.Bind(wx.EVT_TEXT_ENTER, self.OnCmdChanged)
             data = self.GetPyData(dragItem)