Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: FIxed F841 in colorrules.py #4490

Merged
merged 2 commits into from
Oct 11, 2024
Merged

wxGUI: FIxed F841 in colorrules.py #4490

merged 2 commits into from
Oct 11, 2024

Conversation

arohanajit
Copy link
Contributor

Made following modifications to fix F841

  • Directly called RunCommand instead of using a variable
  • Printed the error message e
  • Removed local variable type which was unused

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Oct 11, 2024
@arohanajit @github-actions
Update gui/wxpython/modules/colorrules.py
87cbb62 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 11, 2024
@petrasovaa petrasovaa merged commit cbc3ff4 into OSGeo:main Oct 11, 2024
26 checks passed
@arohanajit arohanajit deleted the 841-colorrules branch October 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arohanajit @petrasovaa