CI(OSGeo4w): Sort and split msys packages into separate lines #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suffix `:p` means to install for the current env only (MINGW_PACKAGE_PREFIX). This allows to have the same package name for different msys2 environments
Not needed since msys2/pactoys#6 changed the defaults when no suffix, and doesn't install for `mingw32` and `mingw64` anymore, only for the current env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the numerous times I've rebased and merged branches containing changes to the msys2 packages used, it has always been hard to follow what changed and always causing conflicts.
This PR splits the package list into separate lines, and are sorted. Just like the action's readme, it uses
>-instead of|or|-to collapse newlines together with spaces (it's a yaml-defined feature, useful in GitHub Actions).It also makes use of the
pacboy:input. This allows to avoid using long, repetitive package prefixes. Without any prefixes, the pacboy wrapper script rewrites package names according to the current environment used before forwarding it to pacman. (The page https://www.msys2.org/docs/package-naming/#avoiding-writing-long-package-names is outdated since msys2/pactoys#6 was merged in may 2024).This makes our package list environment-independent, so in theory that part of our CI is ready for an eventual switch to any of the other 4 msys2 envs, like UCRT64 for example, or a matrix strategy testing them all out. https://www.msys2.org/docs/environments/#overview
The time used is about the same between using pacboy or not (I cannot tell a difference as runner speed variation can account for these < 5-8 seconds difference I see). Cache with or without pacboy, and no cache with or without pacboy are similar, so pacboy isn't a factor here. Only easier to read.