-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CQ: Add .editorconfig and validate repo against it #4792
Draft
echoix
wants to merge
17
commits into
OSGeo:main
Choose a base branch
from
echoix:editorconfig-checker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,771
−2,648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theres 7 bat files to change line endings too |
echoix
force-pushed
the
editorconfig-checker
branch
2 times, most recently
from
December 8, 2024 23:17
3ea0708
to
ba1d323
Compare
echoix
force-pushed
the
editorconfig-checker
branch
from
December 22, 2024 14:19
ba1d323
to
a9c81e7
Compare
echoix
force-pushed
the
editorconfig-checker
branch
from
December 22, 2024 14:27
a9c81e7
to
025c29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be rebased after #4790 and #4791, to drop repeated commits. This is intended to be a draft, and would like to separate the change of line endings stored to CRLF for some files (plus the .gitattributes file change) to be in another commit, easier to cherry-pick afterwards.
With an .editorconfig file, most editors will adjust some preferences to match these settings. For example, setting to trim lines on some file types will have the whitespace trimmed when saving the file, preventing the situation where I regularly need to remove some files that slept through, as we had no CI to enforce it. Setting whether spaces or tabs are used, the indent size, whether to always ensure a new line is present on save. Plugins can accept more domain-specific settings, but appart from the couple of basic properties that are supported by all implementations, the rest is more like a preference if the plugins support the custom properies. For example, Intellij (Pycharm) uses many keys supported only by them, and in CSharp+Visual Basic, editorconfig files are used to select ALL the formatting choices and enable/silence/change the severity of some warnings, supported with more than just the Visual Studio IDE.
This PR: