Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d.histogram: Fix Copy into buffer size issue #4795

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

ShubhamDesai
Copy link
Contributor

This pull request fixes issue identified by Coverity Scan (CID : 1208334)
Used G_strlcpy() to fix this issue.

@github-actions github-actions bot added C Related code is in C module display labels Dec 3, 2024
display/d.histogram/pie.c Outdated Show resolved Hide resolved
@nilason nilason added this to the 8.5.0 milestone Dec 3, 2024
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the unsorted headers were the only remaining problem here from the previous review from @nilason, this is now complete. I'm still leaving an opportunity to find other problems or object, then I'll merge

@echoix
Copy link
Member

echoix commented Dec 4, 2024

Let's go!

@echoix echoix merged commit 8828094 into OSGeo:main Dec 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C display module
Projects
Development

Successfully merging this pull request may close these issues.

3 participants