Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporal: Fix bare except statements with specific error handling #4805

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

arohanajit
Copy link
Contributor

Fixes 5 instances of bare except (E722) in python/grass/temporal/:

core.py:

  1. Line 55: ImportError is appropriate as it's specifically handling optional psycopg2 import
  2. Line 417: Exception is used as get_tgis_metadata() is designed to return None for any metadata access failure
  3. Line 1504: sqlite3.Error/psycopg2.Error catch database execution errors from their respective drivers
  4. Line 1547: sqlite3.Error/psycopg2.Error catch transaction execution errors from their respective drivers

abstract_space_time_dataset.py:
5. Line 2466: FatalError/Exception handle mapset validation and database errors from interface layer

@github-actions github-actions bot added Python Related code is in Python libraries labels Dec 5, 2024
@echoix echoix added the conflicts/needs rebase Rebase to or merge with the latest base branch is needed label Dec 8, 2024
@echoix
Copy link
Member

echoix commented Dec 10, 2024

@arohanajit Can you address the conflicts when you have the chance?

@echoix echoix removed the conflicts/needs rebase Rebase to or merge with the latest base branch is needed label Dec 12, 2024
@echoix
Copy link
Member

echoix commented Dec 12, 2024

Solved conflict in .flake8 file

@echoix echoix enabled auto-merge (squash) December 12, 2024 01:23
@echoix echoix disabled auto-merge December 12, 2024 01:23
@echoix echoix enabled auto-merge (squash) December 12, 2024 01:24
@echoix echoix merged commit 3b1d889 into OSGeo:main Dec 12, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 12, 2024
@arohanajit
Copy link
Contributor Author

@echoix Thanks for doing this, I got done with my finals just yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants