gui: Fix possibly indexing None in psmap.utils.convertRGB #4875
+22
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully type check and annotate convertRGB() and the grass.script.core.parse_color() functions
github-actions
bot
added
GUI
ninsbl
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully type check and annotate convertRGB() and the grass.script.core.parse_color() functions
The psmap.utils.convertRGB is in fact two separate functions, that takes two different kinds of inputs and outputs the other kind. It is correctly represented with an overload.
All places where grass.script.core.parse_color() was used were checked, and it was only here. The generator inside the tuple constructor was changed to a fixed size tuple literal, in order to have simpler signature than
tuple[float, float, float] | tuple[float, ...] | None, where thetuple[float, ...]is for tuples of float of unknown length, which had an impact on static analysis in convertRGB.I needed to wait for #4873 to be merged to avoid conflicts, they were successive commits in my pylint 3 working branch.