Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass7 manual: document --config parameters #532
grass7 manual: document --config parameters #532
Changes from 2 commits
c985e9d
bfd4abc
e53dac7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I actually assumed in my previous comment that the answer is that this is WIP. I do get the same info from running the command, but I don't think people will guess what
svn_revision
refers to. I'm not sure what it is now without checking the code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may mark
svn_revision
here as deprecated.It refers to
VERSIONNUMBER
:grass/lib/init/grass.py
Line 2023 in b74dfd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@landam suggested
libgis_revision
(but only in GRASS 8), see #405 (comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERSIONNUMBER which actually refers to ...? Whole include directory, i.e., the whole C/C++ API/ABI I guess. The other candidates I can think of are gis.h, libgrass_gis.so source code, or GRASS version.
We can add the new name now. We just have to keep the old one as @landam suggests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wenzeslaus I think adding a new config option
libgis_revision
should be part of a different PR since Python code is involved.