grass.script: Remove build vars from setup.py #6391
Conversation
Remove build vars from setup and use the existing dependency on grass.app.runtime to get the information. Additionally, move some of the parametrization to grass.app.runtime because now, both the functions executing the setup steps and the variable are there, so there is no reason to supply these from the outside. Config dir does not require version, but I kept a general function there which is used in g.extension and in GUI because these use the runtime-obtained version as opposed to the one from grass.app.runtime (difference between running system and setup of the env). I removed the build variables from the documentation which makes it a little simpler to edit, although less explicit assuming that the version usage there was actually correct. The example needs more unrelated edits, so I'm keeping it as is.
github-actions
bot
added
GUI
|
Unrelated but cool: Pylint in CI uniquely identified a parameter problems other code checks did not, at least not the local ones (I didn't let the actual tests to run in CI). |
|
I did not touch CMake build here, but it seems that the corresponding configure_file(script/setup.py ${OUTDIR}/${PYDIR_GRASS}/script/setup.py
COPYONLY) |
|
I removed the special line for setup.py from CMakeList.txt. Unrelated, but i.smap test failed again here. |
It should have been something similar to
If you removed string replace tags in that file, that is fine. |
Remove build vars from setup and use the existing dependency on grass.app.runtime to get the information. Additionally, move some of the parametrization to grass.app.runtime because now, both the functions executing the setup steps and the variable are there, so there is no reason to supply these from the outside.
Config dir does not require version, but I kept a general function there which is used in g.extension and in GUI because these use the runtime-obtained version as opposed to the one from grass.app.runtime (difference between running system and setup of the env).
I removed the build variables from the documentation which makes it a little simpler to edit, although less explicit assuming that the version usage there was actually correct. The example needs more unrelated edits, so I'm keeping it as is.